 Chromium Code Reviews
 Chromium Code Reviews Issue 4635007:
  When an extension is uninstalled, close all desktop notifications from that e...  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/
    
  
    Issue 4635007:
  When an extension is uninstalled, close all desktop notifications from that e...  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/| Index: chrome/browser/notifications/notification_ui_manager.h | 
| =================================================================== | 
| --- chrome/browser/notifications/notification_ui_manager.h (revision 65581) | 
| +++ chrome/browser/notifications/notification_ui_manager.h (working copy) | 
| @@ -7,6 +7,7 @@ | 
| #pragma once | 
| #include <deque> | 
| +#include <string> | 
| #include "base/id_map.h" | 
| #include "base/scoped_ptr.h" | 
| @@ -43,9 +44,13 @@ | 
| virtual void Add(const Notification& notification, | 
| Profile* profile); | 
| - // Removes a notification. | 
| - virtual bool Cancel(const Notification& notification); | 
| + // Removes any notifications matching the supplied ID. | 
| 
Andrew T Wilson (Slow)
2010/11/11 21:09:50
document the return value.
 
John Gregg
2010/11/11 23:17:46
Done.
 | 
| + virtual bool CancelById(const std::string& notification_id); | 
| + // Removes any notifications matching the supplied source origin | 
| + // (which could be an extension ID). | 
| + virtual bool CancelAllBySourceOrigin(const GURL& source_origin); | 
| 
Andrew T Wilson (Slow)
2010/11/11 21:09:50
document the return value. BTW, I don't think anyo
 
John Gregg
2010/11/11 23:17:46
Done.
 | 
| + | 
| // Returns balloon collection. | 
| BalloonCollection* balloon_collection() { | 
| return balloon_collection_.get(); |