Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/notifications/balloon_collection.h

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/balloon_collection.h
===================================================================
--- chrome/browser/notifications/balloon_collection.h (revision 65581)
+++ chrome/browser/notifications/balloon_collection.h (working copy)
@@ -9,11 +9,13 @@
#pragma once
#include <deque>
+#include <string>
#include "base/callback.h"
#include "base/scoped_ptr.h"
class Balloon;
+class GURL;
class Notification;
class Profile;
@@ -44,10 +46,14 @@
virtual void Add(const Notification& notification,
Profile* profile) = 0;
- // Removes a balloon from the collection if present. Returns
+ // Removes any balloons that have this notification id. Returns
// true if anything was removed.
- virtual bool Remove(const Notification& notification) = 0;
+ virtual bool RemoveById(const std::string& id) = 0;
+ // Removes any balloons that have this source origin. Returns
+ // true if anything was remove.
Andrew T Wilson (Slow) 2010/11/11 21:09:50 nit: was remove -> was removed
John Gregg 2010/11/11 23:17:46 Done.
+ virtual bool RemoveBySourceOrigin(const GURL& source_origin) = 0;
+
// Is there room to add another notification?
virtual bool HasSpace() const = 0;

Powered by Google App Engine
This is Rietveld 408576698