Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 4633004: NTP: Fix position of the notification and the login name. (Closed)

Created:
10 years, 1 month ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

NTP: Fix position of the notification and the login name. BUG=None TEST=Remove a most visited site. The notification should be shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65596

Patch Set 1 #

Patch Set 2 : More margin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/resources/new_new_tab.css View 1 5 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
10 years, 1 month ago (2010-11-09 22:13:51 UTC) #1
arv (Not doing code reviews)
10 years, 1 month ago (2010-11-09 23:01:10 UTC) #2
Aaron Boodman
LGTM, sorry for introducing the bug.
10 years, 1 month ago (2010-11-09 23:04:11 UTC) #3
mirandac
10 years, 1 month ago (2010-11-09 23:42:18 UTC) #4
Thanks, Erik -- LGTM.

Powered by Google App Engine
This is Rietveld 408576698