Issue 4632002: Make browser_tests obey BROWSER_WRAPPER, like how ui_tests do.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4632002: Make browser_tests obey BROWSER_WRAPPER, like how ui_tests do. (Closed)

Created:
10 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make browser_tests obey BROWSER_WRAPPER, like how ui_tests do. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65602

Patch Set 1 #

Patch Set 2 : ok #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/test/out_of_proc_test_runner.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Elsewhere we already suggest running with BROWSER_WRAPPER='gdb --args'

10 years, 1 month ago (2010-11-10 00:11:28 UTC) #1

Evan Martin

For reference http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/test/ui/ui_test.cc&q=browser_wrapper&exact_package=chromium&sa=N&cd=1&ct=rc&l=771

10 years, 1 month ago (2010-11-10 00:12:03 UTC) #2

Paweł Hajdan Jr.

10 years, 1 month ago (2010-11-10 11:50:39 UTC) #4

Hello, code duplication!

Looks like something to move to chrome/test/test_launcher_utils. Could you do a
follow-up CL?

P.S. Good catch!

Expand Messages | Collapse Messages