Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 463056: GTK: hook up drag and drop of browser actions (for reordering).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_toolbar_model.cc
===================================================================
--- chrome/browser/extensions/extension_toolbar_model.cc (revision 34134)
+++ chrome/browser/extensions/extension_toolbar_model.cc (working copy)
@@ -33,6 +33,35 @@
observers_.RemoveObserver(observer);
}
+void ExtensionToolbarModel::MoveBrowserAction(Extension* extension,
+ int index) {
+ ExtensionList::iterator pos = std::find(begin(), end(), extension);
+ if (pos == end()) {
+ NOTREACHED();
+ return;
+ }
+ toolitems_.erase(pos);
+
+ int i = 0;
+ bool inserted = false;
+ for (ExtensionList::iterator iter = begin(); iter != end(); ++iter, ++i) {
+ if (i == index) {
+ toolitems_.insert(pos, extension);
+ inserted = true;
+ break;
+ }
+ }
+
+ if (!inserted) {
+ DCHECK_EQ(index, static_cast<int>(toolitems_.size()));
+ index = toolitems_.size();
+
+ toolitems_.push_back(extension);
+ }
+
+ FOR_EACH_OBSERVER(Observer, observers_, BrowserActionMoved(extension, index));
+}
+
void ExtensionToolbarModel::Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.h ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698