Issue 462043: By default use the most recently built image when modifying an image for test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 462043: By default use the most recently built image when modifying an image for test. (Closed)

Created:
11 years ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

By default use the most recently built image when modifying an image for test. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=344

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/scripts/mod_image_for_test.sh	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

11 years ago (2009-12-07 22:14:11 UTC) #2

LGTM, although I would have probably used the get_latest_image.sh script -- it
might be easier to maintain this way (well, image_to_usb.sh is not using it
either).

http://codereview.chromium.org/462043/diff/1/2
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/462043/diff/1/2#newcode14
src/scripts/mod_image_for_test.sh:14: DEFAULT_IMAGE="${IMAGES_DIR}/$(ls -t
$IMAGES_DIR 2>&-| head -1)/rootfs.image"
Does it make sense to use the get_latest_image.sh script instead?

Expand Messages | Collapse Messages