Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: chrome/browser/renderer_host/buffered_resource_handler.cc

Issue 462027: Use factory to create histograms, and refcounts to track lifetimes... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/buffered_resource_handler.cc
===================================================================
--- chrome/browser/renderer_host/buffered_resource_handler.cc (revision 33932)
+++ chrome/browser/renderer_host/buffered_resource_handler.cc (working copy)
@@ -30,18 +30,23 @@
void RecordSnifferMetrics(bool sniffing_blocked,
bool we_would_like_to_sniff,
const std::string& mime_type) {
- static BooleanHistogram nosniff_usage("nosniff.usage");
- nosniff_usage.SetFlags(kUmaTargetedHistogramFlag);
- nosniff_usage.AddBoolean(sniffing_blocked);
+ static scoped_refptr<Histogram> nosniff_usage =
+ BooleanHistogram::BooleanHistogramFactoryGet("nosniff.usage");
+ nosniff_usage->SetFlags(kUmaTargetedHistogramFlag);
+ nosniff_usage->AddBoolean(sniffing_blocked);
if (sniffing_blocked) {
- static BooleanHistogram nosniff_otherwise("nosniff.otherwise");
- nosniff_otherwise.SetFlags(kUmaTargetedHistogramFlag);
- nosniff_otherwise.AddBoolean(we_would_like_to_sniff);
+ static scoped_refptr<Histogram> nosniff_otherwise =
+ BooleanHistogram::BooleanHistogramFactoryGet(
+ "nosniff.otherwise");
+ nosniff_otherwise->SetFlags(kUmaTargetedHistogramFlag);
+ nosniff_otherwise->AddBoolean(we_would_like_to_sniff);
- static BooleanHistogram nosniff_empty_mime_type("nosniff.empty_mime_type");
- nosniff_empty_mime_type.SetFlags(kUmaTargetedHistogramFlag);
- nosniff_empty_mime_type.AddBoolean(mime_type.empty());
+ static scoped_refptr<Histogram> nosniff_empty_mime_type =
+ BooleanHistogram::BooleanHistogramFactoryGet(
+ "nosniff.empty_mime_type");
+ nosniff_empty_mime_type->SetFlags(kUmaTargetedHistogramFlag);
+ nosniff_empty_mime_type->AddBoolean(mime_type.empty());
}
}

Powered by Google App Engine
This is Rietveld 408576698