Issue 462025: Better handling of allocation alignment in generated code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 462025: Better handling of allocation alignment in generated code... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Better handling of allocation alignment in generated code Calculate the aligned size of strings when allocating from generated code using kObjectAlignmentMask Add native code assert to make sure allocation from generated code keeps alignment. Committed: http://code.google.com/p/v8/source/detail?r=3415

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -11 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/ia32/macro-assembler-ia32.cc	View		4 chunks	+24 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/462025/diff/1/3 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/462025/diff/1/3#newcode690 src/ia32/macro-assembler-ia32.cc:690: #ifdef DEBUG Please use the flag debug_code, so ...

11 years ago (2009-12-04 07:33:11 UTC) #2

Søren Thygesen Gjesse

11 years ago (2009-12-04 07:57:22 UTC) #3

http://codereview.chromium.org/462025/diff/1/3
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/462025/diff/1/3#newcode690
src/ia32/macro-assembler-ia32.cc:690: #ifdef DEBUG
On 2009/12/04 07:33:12, Mads Ager wrote:
> Please use the flag debug_code, so that we only generate different code in
debug
> mode if passing that flag.

Done.

Expand Messages | Collapse Messages