Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 462019: Added recording of heap and global handle stats in a stack-allocated (Closed)

Created:
11 years ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added recording of heap and global handle stats in a stack-allocated struct on fatal out of memory. This should cause the information to be included in minidumps so we can get a better idea of the state of v8 on OOMs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M src/api.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/global-handles.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/global-handles.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/heap.h View 3 chunks +25 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years ago (2009-12-03 10:08:19 UTC) #1
Mads Ager (chromium)
11 years ago (2009-12-03 10:11:33 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698