Make sure that ffmpeg returning us an invalid stream cannot damage us too...

Make sure that ffmpeg returning us an invalid stream cannot damage us too
badly.

BUG=62127
TEST=Added by Andrew


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65346

[Chris Evans, 2010-11-06 00:00:05]

Simple enough for now :)

[scherkus (not reviewing), 2010-11-08 00:44:49]

LGTM

[fbarchard, 2010-11-08 15:55:47]

http://codereview.chromium.org/4619001/diff/1/2
File media/filters/ffmpeg_demuxer.cc (right):

http://codereview.chromium.org/4619001/diff/1/2#newcode533
media/filters/ffmpeg_demuxer.cc:533: size_t i = packet->stream_index;
Why create a new variable (i)?
FFmpegDemuxerStream* demuxer_stream = NULL;
if (packet->stream_index < packet_streams_.size()) {
  demuxer_stream = packet_streams_[packet->stream_index];
}

[Chris Evans, 2010-11-08 18:36:07]

On 2010/11/08 15:55:47, fbarchard wrote:
> http://codereview.chromium.org/4619001/diff/1/2
> File media/filters/ffmpeg_demuxer.cc (right):
> 
> http://codereview.chromium.org/4619001/diff/1/2#newcode533
> media/filters/ffmpeg_demuxer.cc:533: size_t i = packet->stream_index;
> Why create a new variable (i)?

To avoiding duplicating the expression "packet->stream_index"

> FFmpegDemuxerStream* demuxer_stream = NULL;
> if (packet->stream_index < packet_streams_.size()) {
>   demuxer_stream = packet_streams_[packet->stream_index];
> }

[fbarchard, 2010-11-08 18:55:35]

ok, but its not necessary for Visual C at least.