Issue 4612001: Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4612001: Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed (Closed)

Created:
10 years, 1 month ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, James Hawkins

CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself. BUG=61988 TEST=Memory bots stay green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65272

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -34 lines)			Patch
M	chrome/browser/autofill/personal_data_manager_unittest.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM, but it seems like someone familiar with the WDS code in question should review ...

10 years, 1 month ago (2010-11-05 23:01:31 UTC) #1

LGTM

Expand Messages | Collapse Messages