Issue 4611001: Change the private image data shared memory handle code to return a native...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4611001: Change the private image data shared memory handle code to return a native... (Closed)

Created:
10 years, 1 month ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the private image data shared memory handle code to return a native memory handle and a size rather than the internal TransportDIB structure. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65482

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
M	chrome/renderer/pepper_plugin_delegate_impl.cc	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
M	ppapi/c/trusted/ppb_image_data_trusted.h	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_delegate.h	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

10 years, 1 month ago (2010-11-08 18:44:35 UTC) #2

On 2010/11/05 22:48:52, brettw wrote:
> 

LGTM.

Expand Messages | Collapse Messages