Add some includes needed by GCC 4.4.0

Add some includes needed by GCC 4.4.0
base/string16.h uses EOF thus #include <stdio.h>
net/disk_cache/trace.cc uses vsnprintf thus #include <stdio.h>

r12777

[Craig Schlenter, 2009-03-16 18:05:23]

Dean: thanks for offering to review this. It seems to have passed on the try
server.

[Mark Mentovai, 2009-03-16 18:20:35]

http://codereview.chromium.org/46092/diff/1/2
File base/string16.h (right):

http://codereview.chromium.org/46092/diff/1/2#newcode29
Line 29: #include <cstdio>
What's wrong with <stdio.h>?

We don't generally include the C++-specific versions of these C system headers
because they're only guaranteed to put things into C++'s std namespace, which is
usually not where we look for them.  For example, do you write printf or
std::printf?  Preprocessor macros are not namespaced, so <cstdio> does get EOF
and there is no std::EOF, but since we use <stdio.h> elsewhere, we should follow
suit here.

http://codereview.chromium.org/46092/diff/1/3
File net/disk_cache/trace.cc (right):

http://codereview.chromium.org/46092/diff/1/3#newcode10
Line 10: #include <stdio.h>
There is an stdio.h on Windows too, does this #include need to be conditional?

[Craig Schlenter, 2009-03-16 18:44:49]

Thanks for the review Mark. Comments inline. I'll make a patch set 3 as well
shortly with conditional stuff dropped from trace.cc

http://codereview.chromium.org/46092/diff/1/2
File base/string16.h (right):

http://codereview.chromium.org/46092/diff/1/2#newcode29
Line 29: #include <cstdio>
On 2009/03/16 18:20:35, Mark Mentovai wrote:
> What's wrong with <stdio.h>?

Fixed.

http://codereview.chromium.org/46092/diff/1/3
File net/disk_cache/trace.cc (right):

http://codereview.chromium.org/46092/diff/1/3#newcode10
Line 10: #include <stdio.h>
On 2009/03/16 18:20:35, Mark Mentovai wrote:
> There is an stdio.h on Windows too, does this #include need to be conditional?

vsnprintf is only being called on non-windows platforms so I only included the
necessary header on non-windows. I haven't changed this in patch set 2 but I can
change it if you'd like.

[Craig Schlenter, 2009-03-30 16:00:11]

On 2009/03/16 18:44:49, Craig Schlenter wrote:
> Thanks for the review Mark. Comments inline. I'll make
> a patch set 3 as well shortly with conditional stuff
> dropped from trace.cc

I fixed the description of the patch now and patch was updated ages ago to just
include stdio.h but I forgot to send something out about it.

[Dean McNamee, 2009-03-30 16:10:51]

I'll leave it up to mix-master-mark.  Thanks for the patch.

On 2009/03/30 16:00:11, Craig Schlenter wrote:
> On 2009/03/16 18:44:49, Craig Schlenter wrote:
> > Thanks for the review Mark. Comments inline. I'll make
> > a patch set 3 as well shortly with conditional stuff
> > dropped from trace.cc
> 
> I fixed the description of the patch now and patch was updated ages ago to
just
> include stdio.h but I forgot to send something out about it.

[Mark Mentovai, 2009-03-30 16:32:29]

LGTM

[Mark Mentovai, 2009-03-30 16:47:59]

Checked in r12777