Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 46048: Rollback v8 DEPS for real ... (Closed)

Created:
11 years, 9 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Rollback v8 DEPS roll (for real) I snagged the wrong rev last time. Reverting back to 11622, which had the comment: --------------- r11622 | ager@chromium.org | 2009-03-12 23:53:03 -0700 (Thu, 12 Mar 2009) | 6 lines Update V8 to version 1.1.1. Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 --------------- This also includes the other file change in 11624: --------------- r11624 | ager@chromium.org | 2009-03-13 02:17:01 -0700 (Fri, 13 Mar 2009) | 6 li nes Update V8 to fix an assertion that does not hold. Add test that tests arbitrary limits on expressions that can be handled without stack overflows to the test list. I have filed a bug report and Kevin is investigating. Review URL: http://codereview.chromium.org/46029 --------------- trb=darin,ager Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11654

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages

Total messages: 4 (0 generated)
jar (doing other things)
11 years, 9 months ago (2009-03-13 18:50:41 UTC) #1
Mads Ager (chromium)
We need to pull out more. I'll be happy to do it.
11 years, 9 months ago (2009-03-13 19:02:56 UTC) #2
jar (doing other things)
11 years, 9 months ago (2009-03-13 19:18:14 UTC) #3
Mads Ager (chromium)
11 years, 9 months ago (2009-03-13 19:18:52 UTC) #4
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698