Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: build/SConscript.main

Issue 46037: Have the gyp build use base SCons, not Hammer components, so it can... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | site_scons/site_tools/chromium_builders.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.main
===================================================================
--- build/SConscript.main (revision 11640)
+++ build/SConscript.main (working copy)
@@ -63,14 +63,20 @@
)
+if ARGUMENTS.get('_GYP'):
+ tool_list = ['chromium_builders']
+else:
+ tool_list = ['component_setup',
+ 'chromium_builders',
+ 'chromium_load_component',
+ 'MSVSNew']
+
+
root_env = Environment(
# MSVSNew in the base environment? Yes, the point is we can (and
# want to) generate Visual Studio project and solution files from
# any platform.
- tools = ['component_setup',
- 'chromium_builders',
- 'chromium_load_component',
- 'MSVSNew'],
+ tools = tool_list,
variables = clvars,
# Requested list of system (shared) libraries, from the comma separated
@@ -190,6 +196,7 @@
# The keyword arguments in the call below (base, breakpad, etc.) can be
# specified in the LOAD= argument to cut down on the build.
+Default(None) # Reset default target to empty.
if root_env.get('_GYP'):
webkit_sconscript = '$WEBKIT_DIR/tools/test_shell/test_shell_main${_GYP}.scons'
else:
@@ -789,22 +796,21 @@
# -------------------------------------------------------------------------
-Default(None) # Reset default target to empty.
+if not root_env.get('_GYP'):
+ modes = GetTargetModes().keys()
-modes = GetTargetModes().keys()
+ if set(modes) - set(['msvs', 'xcode']):
+ # There's at least one mode being built besides the platform-
+ # independent 'msvs' or 'xcode' modes. Build the current
+ # build_component's Alias as default--that is, "base" when we're
+ # in the base/ subdirectory, "chrome" under chrome/, etc.
+ Import('build_component')
+ Default(Alias(build_component)) # Set default target based on where built.
-if set(modes) - set(['msvs', 'xcode']):
- # There's at least one mode being built besides the platform-
- # independent 'msvs' or 'xcode' modes. Build the current
- # build_component's Alias as default--that is, "base" when we're
- # in the base/ subdirectory, "chrome" under chrome/, etc.
- Import('build_component')
- Default(Alias(build_component)) # Set default target based on where built.
+ if 'msvs' in modes:
+ # We're in --mode=msvs, so add its Alias(es) to the default targets.
+ Default(Alias('msvs'))
-if 'msvs' in modes:
- # We're in --mode=msvs, so add its Alias(es) to the default targets.
- Default(Alias('msvs'))
-
# -------------------------------------------------------------------------
# This must occur after BuildComponents so that the dependency graph
« no previous file with comments | « DEPS ('k') | site_scons/site_tools/chromium_builders.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698