Issue 46037: Have the gyp build use base SCons, not Hammer components, so it can...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46037: Have the gyp build use base SCons, not Hammer components, so it can... (Closed)

Created:
11 years, 9 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Have the gyp build use base SCons, not Hammer components, so it can control the Alias namespace directly and set appropriate default targets. This currently switches within the various Chrome*() calls. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11657

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -26 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/SConscript.main	View	3 chunks	+23 lines, -17 lines	0 comments	Download
M	site_scons/site_tools/chromium_builders.py	View	1 chunk	+29 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Not exactly sure what's going on in these files, but syntactically it LGTM.

11 years, 9 months ago (2009-03-13 17:46:00 UTC) #2

sgk

11 years, 9 months ago (2009-03-13 18:01:10 UTC) #3

Updated:  DEPS roll for latest gyp rev.
TBR based on previous lgtm.

Expand Messages | Collapse Messages