crash-reporter: Avoid writing through symlinks.

user_collector.h

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef _CRASH_REPORTER_USER_COLLECTOR_H_
 #define _CRASH_REPORTER_USER_COLLECTOR_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 34 matching lines @@
   // Set (override the default) core file pattern.
   void set_core_pattern_file(const std::string &pattern) {
     core_pattern_file_ = pattern;
   }
 
  private:
   friend class UserCollectorTest;
   FRIEND_TEST(UserCollectorTest, CopyOffProcFilesBadPath);
   FRIEND_TEST(UserCollectorTest, CopyOffProcFilesBadPid);
   FRIEND_TEST(UserCollectorTest, CopyOffProcFilesOK);
-  FRIEND_TEST(UserCollectorTest, ForkExecAndPipe);
   FRIEND_TEST(UserCollectorTest, GetIdFromStatus);
   FRIEND_TEST(UserCollectorTest, GetProcessPath);
   FRIEND_TEST(UserCollectorTest, GetSymlinkTarget);
   FRIEND_TEST(UserCollectorTest, GetUserInfoFromName);
 
   // Enumeration to pass to GetIdFromStatus.  Must match the order
   // that the kernel lists IDs in the status file.
   enum IdKind {
     kIdReal = 0,  // uid and gid
     kIdEffective = 1,  // euid and egid
@@ skipping 22 matching lines @@
 
   bool CopyOffProcFiles(pid_t pid, const FilePath &process_map);
   // Determines the crash directory for given pid based on pid's owner,
   // and creates the directory if necessary with appropriate permissions.
   // Returns true whether or not directory needed to be created, false on
   // any failure.
   bool GetCreatedCrashDirectory(pid_t pid,
                                 FilePath *crash_file_path,
                                 bool *out_of_capacity);
   bool CopyStdinToCoreFile(const FilePath &core_path);
-  int ForkExecAndPipe(std::vector<const char *> &arguments,
-                      const char *output_file);
   bool RunCoreToMinidump(const FilePath &core_path,
                          const FilePath &procfs_directory,
                          const FilePath &minidump_path,
                          const FilePath &temp_directory);
   bool ConvertCoreToMinidump(pid_t pid,
                              const FilePath &container_dir,
                              const FilePath &core_path,
                              const FilePath &minidump_path);
   bool ConvertAndEnqueueCrash(int pid, const std::string &exec_name,
                               bool *out_of_capacity);
 
   bool generate_diagnostics_;
   std::string core_pattern_file_;
   std::string our_path_;
   bool initialized_;
 
   // String containing the current log of crash handling errors.
   std::string error_log_;
 
   static const char *kUserId;
   static const char *kGroupId;
 };
 
 #endif  // _CRASH_REPORTER_USER_COLLECTOR_H_