Issue 4603001: crash-reporter: Avoid writing through symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4603001: crash-reporter: Avoid writing through symlinks. (Closed)

Created:
10 years, 1 month ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crash-reporter.git@master

Visibility:
Public.

Description

crash-reporter: Avoid writing through symlinks. BUG=7987 TEST=bvts Change-Id: I875adeb5073936e790beb93f6a223a1642131cbd Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e70f859

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to review #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -146 lines)			Patch
M	crash_collector.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	crash_collector.cc	View	1	3 chunks	+78 lines, -1 line	0 comments	Download
M	crash_collector_test.cc	View		4 chunks	+121 lines, -7 lines	0 comments	Download
M	kernel_collector.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	user_collector.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	user_collector.cc	View		3 chunks	+4 lines, -63 lines	0 comments	Download
M	user_collector_test.cc	View		3 chunks	+1 line, -69 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 1 month ago (2010-11-05 23:22:37 UTC) #2

LGTM

http://codereview.chromium.org/4603001/diff/1/2
File crash_collector.cc (right):

http://codereview.chromium.org/4603001/diff/1/2#newcode70
crash_collector.cc:70: int fd = open(filename.value().c_str(),
Theoretically, you should HANDLE_EINTR here too, I think.

http://codereview.chromium.org/4603001/diff/1/2#newcode112
crash_collector.cc:112: int output_handle = creat(output_file, 0700);
HANDLE_EINTR

Expand Messages | Collapse Messages