Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 460153: Add setup.py for installation (Closed)

Created:
11 years ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, sgk
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add setup.py for installation. BUG=119 Committed: http://code.google.com/p/gyp/source/detail?r=767

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A MANIFEST View 1 chunk +21 lines, -0 lines 0 comments Download
A setup.py View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
http://codereview.chromium.org/460153/diff/1/3 File setup.py (right): http://codereview.chromium.org/460153/diff/1/3#newcode12 setup.py:12: install_cmd = self.get_finalized_command('install') mixture of 2 and 4 space ...
11 years ago (2009-12-09 00:40:06 UTC) #1
sgk
http://codereview.chromium.org/460153/diff/1/3 File setup.py (right): http://codereview.chromium.org/460153/diff/1/3#newcode13 setup.py:13: lib_dir = getattr(install_cmd, 'install_lib') Readability: install_cmd.install_lib (But should use ...
11 years ago (2009-12-09 10:02:43 UTC) #2
sgk
Just hit me when I woke up, distutils knows how and where to install scripts, ...
11 years ago (2009-12-09 17:13:20 UTC) #3
agl
I ran the commands that fta listed in the bug, and here's the contents of ...
11 years ago (2009-12-11 19:24:21 UTC) #4
sgk
11 years ago (2009-12-11 19:28:50 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698