Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: media/base/buffers.h

Issue 46015: Buffer interface is not uint8*. Slight change to way data buffers are create... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/data_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/buffers.h
===================================================================
--- media/base/buffers.h (revision 11456)
+++ media/base/buffers.h (working copy)
@@ -97,7 +97,7 @@
class Buffer : public StreamSample {
public:
// Returns a read only pointer to the buffer data.
- virtual const char* GetData() const = 0;
+ virtual const uint8* GetData() const = 0;
// Returns the size of valid data in bytes.
virtual size_t GetDataSize() const = 0;
@@ -106,15 +106,18 @@
class WritableBuffer : public Buffer {
public:
- // Returns a read-write pointer to the buffer data.
- virtual char* GetWritableData() = 0;
+ // Returns a read-write pointer to the buffer data. When this method is
+ // called, any pointers previously returned from this method are invalid, and
+ // any data previously written to the buffer is invalid. The buffer size
+ // is guaranteed to be at least the size of |buffer_size|. The size
+ // that the GetDataSize() method will return is set to |buffer_size|.
+ // If, after filling the buffer, the caller wants to set the size to a smaller
+ // value then they can call the SetDataSize() method.
+ virtual uint8* GetWritableData(size_t buffer_size) = 0;
// Updates the size of valid data in bytes, which must be less than or equal
- // to GetBufferSize.
+ // to the |buffer_size| passed to GetWritableData().
virtual void SetDataSize(size_t data_size) = 0;
-
- // Returns the maximum allocated size for this buffer.
- virtual size_t GetBufferSize() const = 0;
};
« no previous file with comments | « no previous file | media/base/data_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698