Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 460139: Compatibility improvements for "ls -l" FTP LIST response format. (Closed)

Created:
11 years ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Compatibility improvements for "ls -l" FTP LIST response format. TEST=Covered by net_unittests. BUG=25520 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34079

Patch Set 1 #

Patch Set 2 : y2038 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -19 lines) Patch
A net/data/ftp/dir-listing-ls-13 View 1 chunk +3 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-13.expected View 1 chunk +26 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-14 View 1 1 chunk +3 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-14.expected View 1 1 chunk +26 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_buffer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.cc View 5 chunks +25 lines, -14 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls_unittest.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
11 years ago (2009-12-08 15:11:23 UTC) #1
eroman
So the main difference here is you detect the column offset per line, rather than ...
11 years ago (2009-12-08 18:32:58 UTC) #2
Paweł Hajdan Jr.
On 2009/12/08 18:32:58, eroman wrote: > So the main difference here is you detect the ...
11 years ago (2009-12-08 20:35:18 UTC) #3
Paweł Hajdan Jr.
11 years ago (2009-12-09 13:51:26 UTC) #4
Just realized that this CL _had_ a test case for different column offsets in
different rows. I just missed that fact when replying earlier. :)

I'll have another part of compatibility fixes soon anyway.

Powered by Google App Engine
This is Rietveld 408576698