Uses X mechanisms to get the screen size.

Uses X mechanisms to get the screen size in the event that there's no window manager to query.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34159

[sky, 2009-12-09 05:12:22]

http://codereview.chromium.org/460134/diff/1/2
File views/screen_gtk.cc (right):

http://codereview.chromium.org/460134/diff/1/2#newcode8
views/screen_gtk.cc:8: #include <gdk/gdkx.h>
nit: move this before gtk include.

http://codereview.chromium.org/460134/diff/1/2#newcode41
views/screen_gtk.cc:41: #if defined(OS_CHROMEOS)
Does this need to be chromeos specific?

http://codereview.chromium.org/460134/diff/1/2#newcode57
views/screen_gtk.cc:57: return gfx::Rect(top_left_x, top_left_y, bot_right_x,
bot_right_y);
Something is wrong here, and it may have always been wrong. gfx::Rect takes
width/height, not bottom right_x/y.

[Chris Masone, 2009-12-09 07:16:53]

http://codereview.chromium.org/460134/diff/1/2
File views/screen_gtk.cc (right):

http://codereview.chromium.org/460134/diff/1/2#newcode8
views/screen_gtk.cc:8: #include <gdk/gdkx.h>
On 2009/12/09 05:12:22, sky wrote:
> nit: move this before gtk include.

Done.

http://codereview.chromium.org/460134/diff/1/2#newcode41
views/screen_gtk.cc:41: #if defined(OS_CHROMEOS)
On 2009/12/09 05:12:22, sky wrote:
> Does this need to be chromeos specific?

it doesn't need to be, no.  I didn't know if the Linux port would want this
functionality, though.  I guess it can't hurt.

http://codereview.chromium.org/460134/diff/1/2#newcode57
views/screen_gtk.cc:57: return gfx::Rect(top_left_x, top_left_y, bot_right_x,
bot_right_y);
On 2009/12/09 05:12:22, sky wrote:
> Something is wrong here, and it may have always been wrong. gfx::Rect takes
> width/height, not bottom right_x/y.

Yeah, looking around on the net, it seems that _NET_WORKAREA is supposed to give
back x/y,width/height, so perhaps this was always wrong.

[sky, 2009-12-09 16:34:34]

LGTM with the following change

http://codereview.chromium.org/460134/diff/4002/7001
File views/screen_gtk.cc (right):

http://codereview.chromium.org/460134/diff/4002/7001#newcode41
views/screen_gtk.cc:41: #if defined(OS_LINUX)
This file is only compiled on linux, so no need for the ifdef.

[Chris Masone, 2009-12-09 17:09:47]

http://codereview.chromium.org/460134/diff/4002/7001
File views/screen_gtk.cc (right):

http://codereview.chromium.org/460134/diff/4002/7001#newcode41
views/screen_gtk.cc:41: #if defined(OS_LINUX)
On 2009/12/09 16:34:34, sky wrote:
> This file is only compiled on linux, so no need for the ifdef.

fixed and committed