ipc/ipc_message_macros.h - Issue 460119: Move the utility process messages to their own file now that we have more tha...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_macros.h

Issue 460119: Move the utility process messages to their own file now that we have more tha... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_macros.h

===================================================================

--- ipc/ipc_message_macros.h (revision 33966)

+++ ipc/ipc_message_macros.h (working copy)

@@ -137,11 +137,9 @@

#if defined(IPC_MESSAGE_MACROS_ENUMS)

#undef IPC_MESSAGE_MACROS_ENUMS

-// TODO(jabdelmalek): we're using the lowest 12 bits of type for the message

-// id, and the highest 4 bits for the channel type. This constrains us to

-// 16 channel types (currently using 8) and 4K messages per type. Should

-// really make type be 32 bits, but then we break automation with older Chrome

-// builds..

+// We're using the lowest 16 bits of type for the message id, and the highest

+// 16 bits for the channel type.

+//

// Do label##PreStart so that automation messages keep the same id as before.

#define IPC_BEGIN_MESSAGES(label) \

enum label##MsgType { \

« no previous file with comments | « chrome/utility/utility_thread.cc ('k') | ipc/ipc_message_utils.h » ('j') | no next file with comments »