Issue 460118: Split Continuous/User build and provide useful version information for continuous builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460118: Split Continuous/User build and provide useful version information for continuous builder (Closed)

Created:
11 years ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Split Continuous/User build and provide useful version information for continuous builder

Patch Set 1 #

Patch Set 2 : versioning #

Patch Set 3 : versioning #

Patch Set 4 : versioning #

Patch Set 5 : versioning #

Patch Set 6 : versioning #

Total comments: 1

Patch Set 7 : versioning #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -86 lines)			Patch
	src/scripts/archive_build.sh	View		2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/scripts/build_image.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/scripts/chromeos_version.sh	View	1 2	1 chunk	+52 lines, -53 lines	0 comments	Download
M	src/scripts/customize_rootfs.sh	View	2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/scripts/enter_chroot.sh	View	2 3 4 5 6	2 chunks	+23 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

11 years ago (2009-12-09 00:25:56 UTC) #4

LGTM w/ comment

http://codereview.chromium.org/460118/diff/3016/3021
File src/scripts/enter_chroot.sh (right):

http://codereview.chromium.org/460118/diff/3016/3021#newcode105
src/scripts/enter_chroot.sh:105: # Get the subversion revision to pass into the
chroot.
change comment to reflect that we're using git, not subversion

Expand Messages | Collapse Messages