Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 460069: Changed recording of heap stats on OOM to store data directly in local (Closed)

Created:
11 years ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed recording of heap stats on OOM to store data directly in local variables rather than in a stack-allocated struct. The struct field values turned out not to be available in minidumps.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -50 lines) Patch
M src/api.cc View 1 2 chunks +43 lines, -9 lines 0 comments Download
M src/global-handles.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/heap.h View 1 1 chunk +20 lines, -18 lines 0 comments Download
M src/heap.cc View 1 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Christian Plesner Hansen
11 years ago (2009-12-04 09:34:45 UTC) #1
Mads Ager (chromium)
LGTM Let's hope this will let us inspect it in windbg.
11 years ago (2009-12-04 09:55:56 UTC) #2
Søren Thygesen Gjesse
http://codereview.chromium.org/460069/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/460069/diff/1/2#newcode130 src/api.cc:130: int new_space_size; How about using a macro for expanding ...
11 years ago (2009-12-04 10:08:09 UTC) #3
Christian Plesner Hansen
11 years ago (2009-12-04 10:15:54 UTC) #4
http://codereview.chromium.org/460069/diff/1/2
File src/api.cc (right):

http://codereview.chromium.org/460069/diff/1/2#newcode130
src/api.cc:130: int new_space_size;
Normally I would have done that but I don't want to do anything that might
confuse windbg.  It appears to be easily confused...

http://codereview.chromium.org/460069/diff/1/5
File src/heap.h (right):

http://codereview.chromium.org/460069/diff/1/5#newcode1107
src/heap.h:1107: public:
Done

Powered by Google App Engine
This is Rietveld 408576698