Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: net/ocsp/nss_ocsp.cc

Issue 460040: Do not set io_loop_ to NULL until we have deleted request_ and set... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Upload before checkin Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ocsp/nss_ocsp.cc
===================================================================
--- net/ocsp/nss_ocsp.cc (revision 33697)
+++ net/ocsp/nss_ocsp.cc (working copy)
@@ -216,16 +216,15 @@
} while (request_->Read(buffer_, kRecvBufferSize, &bytes_read));
if (!request_->status().is_io_pending()) {
- MessageLoop* io_loop = io_loop_;
+ delete request_;
+ request_ = NULL;
+ io_loop_->RemoveDestructionObserver(this);
{
AutoLock autolock(lock_);
finished_ = true;
io_loop_ = NULL;
}
cv_.Signal();
- delete request_;
- request_ = NULL;
- io_loop->RemoveDestructionObserver(this);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698