Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/autofill/form_structure.h

Issue 4591001: Display a warning when autofill is disabled for a website. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile on ChromeOS... Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure.h
diff --git a/chrome/browser/autofill/form_structure.h b/chrome/browser/autofill/form_structure.h
index 77e106f48a6454af5ccf9257c0e94da90abd5464..fe4c5dadee127b09f39eeae73eea8e7db0563a69 100644
--- a/chrome/browser/autofill/form_structure.h
+++ b/chrome/browser/autofill/form_structure.h
@@ -61,22 +61,15 @@ class FormStructure {
// the form name, and the form field names in a 64-bit hash.
std::string FormSignature() const;
- // Runs a quick heuristic to rule out pages but obviously not auto-fillable,
- // like google/yahoo/msn search, etc.
- bool IsAutoFillable() const;
+ // Runs a quick heuristic to rule out forms that are obviously not
+ // auto-fillable, like google/yahoo/msn search, etc. The requirement that the
+ // form's method be POST is only applied if |require_method_post| is true.
+ bool IsAutoFillable(bool require_method_post) const;
// Returns true if at least one of the form fields relevant for AutoFill
// is not empty.
bool HasAutoFillableValues() const;
- // Returns true if at least one of the form fields is a billing field, which
- // includes billing address fields and credit card fields.
- bool HasBillingFields() const;
-
- // Returns true if at least one of the form fields is a non-billing field,
- // which includes billing address fields and credit card fields.
- bool HasNonBillingFields() const;
-
// Resets |autofill_count_| and counts the number of auto-fillable fields.
// This is used when we receive server data for form fields. At that time,
// we may have more known fields than just the number of fields we matched
@@ -84,7 +77,9 @@ class FormStructure {
void UpdateAutoFillCount();
// Returns true if this form matches the structural requirements for AutoFill.
- bool ShouldBeParsed() const;
+ // The requirement that the form's method be POST is only applied if
+ // |require_method_post| is true.
+ bool ShouldBeParsed(bool require_method_post) const;
// Sets the possible types for the field at |index|.
void set_possible_types(int index, const FieldTypeSet& types);
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/form_structure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698