 Chromium Code Reviews
 Chromium Code Reviews Issue 4591001:
  Display a warning when autofill is disabled for a website.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 4591001:
  Display a warning when autofill is disabled for a website.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/renderer_host/render_view_host_delegate.h | 
| diff --git a/chrome/browser/renderer_host/render_view_host_delegate.h b/chrome/browser/renderer_host/render_view_host_delegate.h | 
| index 020fadcca0465e13f784a3706e35cc71662e67ca..d92c68717ce64995f3b2de3338c6014cc37ae56a 100644 | 
| --- a/chrome/browser/renderer_host/render_view_host_delegate.h | 
| +++ b/chrome/browser/renderer_host/render_view_host_delegate.h | 
| @@ -521,10 +521,7 @@ class RenderViewHostDelegate { | 
| // query. When the database thread is finished, the AutocompleteHistory | 
| // manager retrieves the calling RenderViewHost and then passes the vector | 
| // of suggestions to RenderViewHost::AutocompleteSuggestionsReturned. | 
| - // Returns true to indicate that FormFieldHistorySuggestionsReturned will be | 
| - // called. | 
| - virtual bool GetAutocompleteSuggestions(int query_id, | 
| - const string16& field_name, | 
| + virtual void GetAutocompleteSuggestions(const string16& field_name, | 
| const string16& user_text) = 0; | 
| // Called when the user has indicated that she wants to remove the specified | 
| @@ -549,13 +546,13 @@ class RenderViewHostDelegate { | 
| virtual void FormsSeen(const std::vector<webkit_glue::FormData>& forms) = 0; | 
| // Called to retrieve a list of AutoFill suggestions from the web database | 
| - // given the name of the field and what the user has already typed in the | 
| - // field. |form_autofilled| is true if the form containing |field| has any | 
| - // auto-filled fields. Returns true to indicate that | 
| - // RenderViewHost::AutoFillSuggestionsReturned has been called. | 
| + // given the name of the field, whether it is autofilled, and what the user | 
| 
dhollowa
2010/11/15 18:47:57
nit: s/autofilled/auto-filled/
 
Ilya Sherman
2010/11/15 22:53:32
Done.
 | 
| + // has already typed in it. If there is a warning to be returned to the | 
| + // user, it is stored into |values|, with corresponding unique id -1. | 
| + // Returns true to indicate that RenderViewHost::AutoFillSuggestionsReturned | 
| + // has been called. | 
| virtual bool GetAutoFillSuggestions( | 
| - int query_id, | 
| - bool form_autofilled, | 
| + bool field_autofilled, | 
| const webkit_glue::FormField& field) = 0; | 
| // Called to fill the FormData object with AutoFill profile information that |