[new http] Normalize line continuations in response headers.

net/http/http_response_headers.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_RESPONSE_HEADERS_H_
 #define NET_HTTP_RESPONSE_HEADERS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/hash_tables.h"
 #include "base/ref_counted.h"
 
 class Pickle;
 class Time;
 class TimeDelta;
 
 namespace net {
 
 // HttpResponseHeaders: parses and holds HTTP response headers.
 class HttpResponseHeaders :
     public base::RefCountedThreadSafe<HttpResponseHeaders> {
  public:
   // Parses the given raw_headers.  raw_headers should be formatted thus:
   // includes the http status response line, each line is \0-terminated, and
   // it's terminated by an empty line (ie, 2 \0s in a row).
+  // (Note that line continuations should have already been joined;
+  // see HttpUtil::AssembleRawHeaders)
   //
   // NOTE: For now, raw_headers is not really 'raw' in that this constructor is
   // called with a 'NativeMB' string on Windows because WinHTTP does not allow
   // us to access the raw byte sequence as sent by a web server.  In any case,
   // HttpResponseHeaders does not perform any encoding changes on the input.
   //
   explicit HttpResponseHeaders(const std::string& raw_headers);
 
   // Initializes from the representation stored in the given pickle.  The data
   // for this object is found relative to the given pickle_iter, which should
@@ skipping 159 matching lines @@
 
   // Tries to extract the status line from a header block, given the first
   // line of said header block.  If the status line is malformed, we'll construct
   // a valid one.  Example input:
   //    HTTP/1.1 200 OK
   // with line_begin and end pointing at the begin and end of this line.
   // Output will be a normalized version of this, with a trailing \n.
   void ParseStatusLine(std::string::const_iterator line_begin,
                        std::string::const_iterator line_end);
 
-  // Tries to extract the header line from a header block, given a single
-  // line of said header block.  If the header is malformed, we skip it.
-  // Example input:
-  //    Content-Length : text/html; charset=utf-8
-  void ParseHeaderLine(std::string::const_iterator line_begin,
-                       std::string::const_iterator line_end);
-
   // Find the header in our list (case-insensitive) starting with parsed_ at
   // index |from|.  Returns string::npos if not found.
   size_t FindHeader(size_t from, const std::string& name) const;
 
   // Add a header->value pair to our list.  If we already have header in our
   // list, append the value to it.
   void AddHeader(std::string::const_iterator name_begin,
                  std::string::const_iterator name_end,
                  std::string::const_iterator value_begin,
                  std::string::const_iterator value_end);
@@ skipping 23 matching lines @@
     bool is_continuation() const { return name_begin == name_end; }
   };
   typedef std::vector<ParsedHeader> HeaderList;
 
   // We keep a list of ParsedHeader objects.  These tell us where to locate the
   // header-value pairs within raw_headers_.
   HeaderList parsed_;
 
   // The raw_headers_ consists of the normalized status line (terminated with a
   // null byte) and then followed by the raw null-terminated headers from the
-  // input that was passed to our constructor.  We preserve the input to
+  // input that was passed to our constructor.  We preserve the input [*] to
   // maintain as much ancillary fidelity as possible (since it is sometimes
   // hard to tell what may matter down-stream to a consumer of XMLHttpRequest).
+  // [*] The status line may be modified.
   std::string raw_headers_;
 
   // This is the parsed HTTP response code.
   int response_code_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpResponseHeaders);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_RESPONSE_HEADERS_H_