Issue 4576001: Move part of scanner.* into scanner-base.* for reuse in preparser scanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4576001: Move part of scanner.* into scanner-base.* for reuse in preparser scanner. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Move part of scanner.* into scanner-base.* for reuse in preparser scanner. Make checks.h not depend on flags.h or global.h (or anything else except include/v8stdint.h). Only checks.cc has the dependencies (so another implementation of checks.cc can be provided by the preparser). Now files depending on checks.h (using ASSERT macros) can include it directly without depending on all of v8.

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+603 lines, -484 lines)			Patch
M	src/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/checks.h	View	4 chunks	+15 lines, -4 lines	0 comments	Download
M	src/checks.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/preparser.h	View	52 chunks	+224 lines, -223 lines	0 comments	Download
M	src/scanner.h	View	2 chunks	+1 line, -120 lines	0 comments	Download
M	src/scanner.cc	View	1 chunk	+0 lines, -136 lines	0 comments	Download
A	src/scanner-base.h	View	1 chunk	+165 lines, -0 lines	1 comment	Download
A	src/scanner-base.cc	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	src/token.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/v8.xcodeproj/project.pbxproj	View	6 chunks	+8 lines, -0 lines	1 comment	Download
M	tools/visual_studio/v8_base.vcproj	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-05 13:29:27 UTC) #2

LGTM

http://codereview.chromium.org/4576001/diff/1/7
File src/scanner-base.h (right):

http://codereview.chromium.org/4576001/diff/1/7#newcode159
src/scanner-base.h:159: 
Excessive spacing.

http://codereview.chromium.org/4576001/diff/1/13
File tools/v8.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/4576001/diff/1/13#newcode118
tools/v8.xcodeproj/project.pbxproj:118: 89A88E1B0E71A69D0043BA31 /*
scanner-base.cc in Sources */ = {isa = PBXBuildFile; fileRef =
897FF1730E719B8F00D62E90 /* scanner-base.cc */; };
Did you just reuse an ID here? That will not fly. Better to not mess with this
file in that case.

Expand Messages | Collapse Messages