Issue 4575001: Crash fix: HTTPS server responds with 407 through non-authenticating proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4575001: Crash fix: HTTPS server responds with 407 through non-authenticating proxy. (Closed)

Created:
10 years, 1 month ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
vandebo (ex-Chrome), eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Crash fix: HTTPS server responds with 407 through non-authenticating proxy. Now, HttpNetworkTransaction::HandleAuthChallenge returns ERR_INVALID_PROXY_AUTHENTICATE when this is detected. BUG=61701 TEST=net_unittests --gtest_filter="*HttpsServerRequestsProxyAuthThroughProxy*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65225

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -0 lines)			Patch
	M	net/http/http_network_transaction.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	net/http/http_network_transaction_unittest.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

10 years, 1 month ago (2010-11-05 19:13:53 UTC) #3

LGTM.

nit, the description mentions wrong error code; should read
ERR_UNEXPECTED_PROXY_AUTH.

Expand Messages | Collapse Messages