Pass wifi available/enabled status to JS at initialization.

Pass wifi available/enabled status to JS at initialization.
(with a couple of minor whitespace fixes).

Without this fix, the status was only passed when network update event
happened and you would see the wrong "Enable Wifi" button even when
Wifi is actually enabled.

BUG=chromium-os:8196
TEST=login with Wifi enabled and open chrome://settings => internet and see if the "Disable Wifi" button appears properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65352

[kochi, 2010-11-05 10:01:24]

Hi Charlie,

Could you review this?

Thanks!

[Charlie Lee, 2010-11-05 16:34:29]

http://codereview.chromium.org/4572001/diff/1/2
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/4572001/diff/1/2#newcode300
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:300:
chromeos::CrosLibrary::Get()->GetNetworkLibrary();
Do you think you can refactor this code and the other code (that does the same
thing) into one method? That way we won't have this kind of bug in the the
future?

http://codereview.chromium.org/4572001/diff/1/3
File chrome/browser/resources/options/chromeos_internet_options.html (right):

http://codereview.chromium.org/4572001/diff/1/3#newcode8
chrome/browser/resources/options/chromeos_internet_options.html:8:
i18n-content="disableWifi"></button>
while you are at it, can you add an extra space to this line in the beginning?

http://codereview.chromium.org/4572001/diff/1/4
File chrome/browser/resources/options/chromeos_internet_options.js (right):

http://codereview.chromium.org/4572001/diff/1/4#newcode66
chrome/browser/resources/options/chromeos_internet_options.js:66:
chrome.send('enableCellular', []);
can you fix this?

http://codereview.chromium.org/4572001/diff/1/4#newcode69
chrome/browser/resources/options/chromeos_internet_options.js:69:
event.target.disabled = true;
and these 2 lines also?

[kochi, 2010-11-08 03:19:20]

Thanks for your quick review!

http://codereview.chromium.org/4572001/diff/1/2
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/4572001/diff/1/2#newcode300
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:300:
chromeos::CrosLibrary::Get()->GetNetworkLibrary();
Yes, of course.

But for safety, I would like to avoid refactoring in this CL and make it in
another CL.

I would like to merge this simple fix to release branch.

http://codereview.chromium.org/4572001/diff/1/3
File chrome/browser/resources/options/chromeos_internet_options.html (right):

http://codereview.chromium.org/4572001/diff/1/3#newcode8
chrome/browser/resources/options/chromeos_internet_options.html:8:
i18n-content="disableWifi"></button>
On 2010/11/05 16:34:30, Charlie Lee wrote:
> while you are at it, can you add an extra space to this line in the beginning?

Done.

http://codereview.chromium.org/4572001/diff/1/4
File chrome/browser/resources/options/chromeos_internet_options.js (right):

http://codereview.chromium.org/4572001/diff/1/4#newcode66
chrome/browser/resources/options/chromeos_internet_options.js:66:
chrome.send('enableCellular', []);
Good catch!
Done.

http://codereview.chromium.org/4572001/diff/1/4#newcode69
chrome/browser/resources/options/chromeos_internet_options.js:69:
event.target.disabled = true;
On 2010/11/05 16:34:30, Charlie Lee wrote:
> and these 2 lines also?

Done.

[Charlie Lee, 2010-11-08 03:40:26]

Please upload the latest and I can give you a lgtm.

On 2010/11/08 03:19:20, tkochi wrote:
> Thanks for your quick review!
> 
> http://codereview.chromium.org/4572001/diff/1/2
> File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):
> 
> http://codereview.chromium.org/4572001/diff/1/2#newcode300
> chrome/browser/chromeos/dom_ui/internet_options_handler.cc:300:
> chromeos::CrosLibrary::Get()->GetNetworkLibrary();
> Yes, of course.
> 
> But for safety, I would like to avoid refactoring in this CL and make it in
> another CL.
> 
> I would like to merge this simple fix to release branch.
> 
> http://codereview.chromium.org/4572001/diff/1/3
> File chrome/browser/resources/options/chromeos_internet_options.html (right):
> 
> http://codereview.chromium.org/4572001/diff/1/3#newcode8
> chrome/browser/resources/options/chromeos_internet_options.html:8:
> i18n-content="disableWifi"></button>
> On 2010/11/05 16:34:30, Charlie Lee wrote:
> > while you are at it, can you add an extra space to this line in the
beginning?
> 
> Done.
> 
> http://codereview.chromium.org/4572001/diff/1/4
> File chrome/browser/resources/options/chromeos_internet_options.js (right):
> 
> http://codereview.chromium.org/4572001/diff/1/4#newcode66
> chrome/browser/resources/options/chromeos_internet_options.js:66:
> chrome.send('enableCellular', []);
> Good catch!
> Done.
> 
> http://codereview.chromium.org/4572001/diff/1/4#newcode69
> chrome/browser/resources/options/chromeos_internet_options.js:69:
> event.target.disabled = true;
> On 2010/11/05 16:34:30, Charlie Lee wrote:
> > and these 2 lines also?
> 
> Done.

[Takayoshi Kochi (Google), 2010-11-08 06:35:53]

Oops, uploaded.

Sorry, I forgot to type the title for new cl and left the console.

On Mon, Nov 8, 2010 at 12:40 PM,  <chocobo@chromium.org> wrote:
> Please upload the latest and I can give you a lgtm.
>
> On 2010/11/08 03:19:20, tkochi wrote:
>>
>> Thanks for your quick review!
>
>> http://codereview.chromium.org/4572001/diff/1/2
>> File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):
>
>> http://codereview.chromium.org/4572001/diff/1/2#newcode300
>> chrome/browser/chromeos/dom_ui/internet_options_handler.cc:300:
>> chromeos::CrosLibrary::Get()->GetNetworkLibrary();
>> Yes, of course.
>
>> But for safety, I would like to avoid refactoring in this CL and make it
>> in
>> another CL.
>
>> I would like to merge this simple fix to release branch.
>
>> http://codereview.chromium.org/4572001/diff/1/3
>> File chrome/browser/resources/options/chromeos_internet_options.html
>> (right):
>
>> http://codereview.chromium.org/4572001/diff/1/3#newcode8
>> chrome/browser/resources/options/chromeos_internet_options.html:8:
>> i18n-content="disableWifi"></button>
>> On 2010/11/05 16:34:30, Charlie Lee wrote:
>> > while you are at it, can you add an extra space to this line in the
>
> beginning?
>
>> Done.
>
>> http://codereview.chromium.org/4572001/diff/1/4
>> File chrome/browser/resources/options/chromeos_internet_options.js
>> (right):
>
>> http://codereview.chromium.org/4572001/diff/1/4#newcode66
>> chrome/browser/resources/options/chromeos_internet_options.js:66:
>> chrome.send('enableCellular', []);
>> Good catch!
>> Done.
>
>> http://codereview.chromium.org/4572001/diff/1/4#newcode69
>> chrome/browser/resources/options/chromeos_internet_options.js:69:
>> event.target.disabled = true;
>> On 2010/11/05 16:34:30, Charlie Lee wrote:
>> > and these 2 lines also?
>
>> Done.
>
>
>
> http://codereview.chromium.org/4572001/show
>



-- 
Takayoshi Kochi

[Charlie Lee, 2010-11-08 07:42:23]

LGTM