Added a EvalCache that caches eval'ed scripts and compiled function boilerpla...

src/runtime.cc

 // Copyright 2006-2008 Google Inc. All Rights Reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3310 matching lines @@
     // through an alias, and the corresponding frame doesn't have a
     // proper eval context set up.
     Object* eval_context = EvalContext();
     if (eval_context->IsFailure()) return eval_context;
     context = Handle<Context>(Context::cast(eval_context));
   } else {
     context = Handle<Context>(Top::context()->global_context());
   }
 
   // Compile eval() source.
+  bool is_global_context = context->IsGlobalContext();

[Kasper Lund, 2008/09/05 09:16:29]

I think you should move this code to the Compiler and use it for scripts too. It
would be nice to be able to just put it in compiler.cc:MakeFunction but that may
be a little to late because the Compile, CompileLazy, CompileEval functions
build script data structures and may do pre-parsing which should be avoided too.
You probably have to refactor it a bit.

[Feng Qian, 2008/09/09 03:42:50]

Done.

   Handle<String> source(String::cast(args[0]));
-  Handle<JSFunction> boilerplate =
-      Compiler::CompileEval(context->IsGlobalContext(), source);
-  if (boilerplate.is_null()) return Failure::Exception();
+  Object* obj = Heap::LookupEvalCache(is_global_context, *source);
+  if (obj->IsFailure()) return obj;
+
+  Handle<JSFunction> boilerplate;
+  if (!obj->IsJSFunction()) {
+    Counters::eval_cache_misses.Increment();
+    boilerplate = Compiler::CompileEval(is_global_context, source);
+    if (boilerplate.is_null()) return Failure::Exception();
+
+    Object* obj =
+        Heap::PutInEvalCache(is_global_context, *source, *boilerplate);
+    if (obj->IsFailure()) return obj;
+
+  } else {
+    Counters::eval_cache_hits.Increment();
+    boilerplate = Handle<JSFunction>(JSFunction::cast(obj));
+  }
+
   Handle<JSFunction> fun =
       Factory::NewFunctionFromBoilerplate(boilerplate, context);
   return *fun;
 }
 
 
 static Object* Runtime_CompileScript(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 4);
 
@@ skipping 1559 matching lines @@
 
 void Runtime::PerformGC(Object* result) {
   Failure* failure = Failure::cast(result);
   // Try to do a garbage collection; ignore it if it fails. The C
   // entry stub will throw an out-of-memory exception in that case.
   Heap::CollectGarbage(failure->requested(), failure->allocation_space());
 }
 
 
 } }  // namespace v8::internal