Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 456001: Move CPU-specific constants from debug.h into the platform-specific directori... (Closed)

Created:
11 years ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move CPU-specific constants from debug.h into the platform-specific directories. The constant for the return sequence length (JSReturnSequenceLength) was defined in debug.h. Since this constant are also needed outside the debugger code I moved them into assembler-xxx.h. Otherwise compiling with debuggersupport=off would fail on ARM. BUG=http://code.google.com/p/v8/issues/detail?id=533 Committed: http://code.google.com/p/v8/source/detail?r=3383

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/fast-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/debug-ia32.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
11 years ago (2009-11-30 14:54:54 UTC) #1
Søren Thygesen Gjesse
11 years ago (2009-11-30 14:59:36 UTC) #2
LGTM, except I am wondering whether the constants should go into CodeGen instead
of Assembler as they are related to how we generate core and not to the
assembler as such.

Powered by Google App Engine
This is Rietveld 408576698