Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: net/http/http_auth_handler_negotiate.h

Issue 4560001: Support specifying the GSSAPI library that will be used. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fix another compile error on Windows Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_factory.cc ('k') | net/http/http_auth_handler_negotiate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate.h
diff --git a/net/http/http_auth_handler_negotiate.h b/net/http/http_auth_handler_negotiate.h
index 5f46ab18e718eb873e401cd064054c4f087e1f19..a19d182da623487599ed0cb17527c407018aa552 100644
--- a/net/http/http_auth_handler_negotiate.h
+++ b/net/http/http_auth_handler_negotiate.h
@@ -72,14 +72,10 @@ class HttpAuthHandlerNegotiate : public HttpAuthHandler {
const BoundNetLog& net_log,
scoped_ptr<HttpAuthHandler>* handler);
- // Set the system library to use. Typically the only callers which need to
- // use this are unit tests which pass in a mocked-out version of the
- // system library.
- // The caller is responsible for managing the lifetime of |*auth_library|,
- // and the lifetime must exceed that of this Factory object and all
- // HttpAuthHandler's that this Factory object creates.
+ // Sets the system library to use, thereby assuming ownership of
+ // |auth_library|.
void set_library(AuthLibrary* auth_library) {
- auth_library_ = auth_library;
+ auth_library_.reset(auth_library);
}
private:
@@ -91,7 +87,7 @@ class HttpAuthHandlerNegotiate : public HttpAuthHandler {
bool first_creation_;
bool is_unsupported_;
#endif
- AuthLibrary* auth_library_;
+ scoped_ptr<AuthLibrary> auth_library_;
};
HttpAuthHandlerNegotiate(AuthLibrary* sspi_library,
« no previous file with comments | « net/http/http_auth_handler_factory.cc ('k') | net/http/http_auth_handler_negotiate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698