Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: net/http/http_auth_handler_negotiate_unittest.cc

Issue 4560001: Support specifying the GSSAPI library that will be used. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fix library handling on Windows; port to ToT Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_handler_negotiate_unittest.cc
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc
index 9f87f782a3dbcfb0a0f01922db9c1189fb6e5d2c..e4a3030c510e86ec3a990fdfd120faf799ad3b84 100644
--- a/net/http/http_auth_handler_negotiate_unittest.cc
+++ b/net/http/http_auth_handler_negotiate_unittest.cc
@@ -31,7 +31,7 @@ namespace net {
class HttpAuthHandlerNegotiateTest : public PlatformTest {
public:
virtual void SetUp() {
- auth_library_.reset(new MockAuthLibrary());
+ auth_library_ = new MockAuthLibrary();
resolver_.reset(new MockHostResolver());
resolver_->rules()->AddIPLiteralRule("alias", "10.0.0.2",
"canonical.example.com");
@@ -39,7 +39,7 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest {
url_security_manager_.reset(new URLSecurityManagerAllow());
factory_.reset(new HttpAuthHandlerNegotiate::Factory());
factory_->set_url_security_manager(url_security_manager_.get());
- factory_->set_library(auth_library_.get());
+ factory_->set_library(auth_library_);
factory_->set_host_resolver(resolver_.get());
}
@@ -205,13 +205,14 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest {
return rv;
}
- MockAuthLibrary* AuthLibrary() { return auth_library_.get(); }
+ MockAuthLibrary* AuthLibrary() { return auth_library_; }
private:
#if defined(OS_WIN)
scoped_ptr<SecPkgInfoW> security_package_;
#endif
- scoped_ptr<MockAuthLibrary> auth_library_;
+ // |auth_library_| will be passed to |factory_| and will then be owned by it.
danno 2010/11/10 16:52:01 |auth_library_| is passed to |factory_|, which ass
Jakob Kummerow (corp) 2010/11/10 17:48:39 Done.
+ MockAuthLibrary* auth_library_;
scoped_ptr<MockHostResolver> resolver_;
scoped_ptr<URLSecurityManager> url_security_manager_;
scoped_ptr<HttpAuthHandlerNegotiate::Factory> factory_;

Powered by Google App Engine
This is Rietveld 408576698