Issue 455020: Remove some of the cache validity checks for for-in enumeration. We...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455020: Remove some of the cache validity checks for for-in enumeration. We... (Closed)

Created:
11 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove some of the cache validity checks for for-in enumeration. We can check for these cases before caching the property names instead. Committed: http://code.google.com/p/v8/source/detail?r=3389

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -26 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/handles.cc	View	4 chunks	+29 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+17 lines, -17 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM! http://codereview.chromium.org/455020/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/455020/diff/1/3#newcode2649 src/objects.cc:2649: if (curr->NumberOfEnumElements() > 0) return false; Seems like ...

11 years ago (2009-12-01 10:21:08 UTC) #2

Mads Ager (chromium)

11 years ago (2009-12-01 10:24:29 UTC) #3

On 2009/12/01 10:21:08, Erik Corry wrote:
> LGTM!
> 
> http://codereview.chromium.org/455020/diff/1/3
> File src/objects.cc (right):
> 
> http://codereview.chromium.org/455020/diff/1/3#newcode2649
> src/objects.cc:2649: if (curr->NumberOfEnumElements() > 0) return false;
> Seems like it would be better to check this when creating the cache and not
save
> the cache.

I agree.  We still need the check here when the cache is there but elements have
been added in the mean time.  But it should be a win to not save the cache if
there are elements.

I'll do this in a separate change.

Expand Messages | Collapse Messages