Issue 455011: Don't use any member variables when sending a sync call...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455011: Don't use any member variables when sending a sync call... (Closed)

Created:
11 years ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't use any member variables when sending a sync call, since SyncChannel could be deleted. BUG=20364 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33414

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -46 lines)			Patch
M	ipc/ipc_sync_channel.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ipc/ipc_sync_channel.cc	View	1	5 chunks	+27 lines, -26 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View		8 chunks	+44 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM It'd be great if there were a way to construct a unit test for ...

11 years ago (2009-12-01 00:30:24 UTC) #2

jam

added test http://codereview.chromium.org/455011/diff/1/2 File ipc/ipc_sync_channel.cc (right): http://codereview.chromium.org/455011/diff/1/2#newcode486 ipc/ipc_sync_channel.cc:486: WaitableEvent* dispatch_event = sync_context()->GetDispatchEvent(); On 2009/12/01 00:30:24, ...

11 years ago (2009-12-01 02:33:52 UTC) #3

LGTM for the test.

Expand Messages | Collapse Messages

Issue 455011: Don't use any member variables when sending a sync call... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages