Issue 4550003: Mark ExternalTabUITest.HostNetworkStackAbortRequest and HostNetworkStackUnresponsiveRenderer flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4550003: Mark ExternalTabUITest.HostNetworkStackAbortRequest and HostNetworkStackUnresponsiveRenderer flaky. (Closed)

Created:
10 years, 1 month ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mark ExternalTabUITest.HostNetworkStackAbortRequest and HostNetworkStackUnresponsiveRenderer flaky. BUG=61023 TEST=trybots TBR=erikkay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65176

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/test/automation/automation_proxy_uitest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

10 years, 1 month ago (2010-11-05 05:46:07 UTC) #2

LGTM

On Thu, Nov 4, 2010 at 7:41 PM, <mattm@chromium.org> wrote:

> Reviewers: Erik Kay,
>
> Description:
> Mark ExternalTabUITest.HostNetworkStackAbortRequest and
> HostNetworkStackUnresponsiveRenderer flaky.
>
> BUG=61023
> TEST=trybots
> TBR=erikkay
>
> Please review this at http://codereview.chromium.org/4550003/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/automation/automation_proxy_uitest.cc
>
>
> Index: chrome/test/automation/automation_proxy_uitest.cc
> diff --git a/chrome/test/automation/automation_proxy_uitest.cc
> b/chrome/test/automation/automation_proxy_uitest.cc
> index
>
d9eb414df93ac1fd268cf4a443e62c917d5c029c..7d8a4326c1a8ee4719eef693acc5c50a543b11e5
> 100644
> --- a/chrome/test/automation/automation_proxy_uitest.cc
> +++ b/chrome/test/automation/automation_proxy_uitest.cc
> @@ -1082,7 +1082,8 @@ TEST_F(ExternalTabUITest, FLAKY_HostNetworkStack) {
>   loop.RunFor(action_max_timeout_ms());
>  }
>
> -TEST_F(ExternalTabUITest, HostNetworkStackAbortRequest) {
> +// Flaky, http://crbug.com/61023.
> +TEST_F(ExternalTabUITest, FLAKY_HostNetworkStackAbortRequest) {
>   scoped_refptr<TabProxy> tab;
>   TimedMessageLoopRunner loop(MessageLoop::current());
>   ASSERT_THAT(mock_, testing::NotNull());
> @@ -1123,7 +1124,8 @@ TEST_F(ExternalTabUITest,
> HostNetworkStackAbortRequest) {
>   loop.RunFor(action_max_timeout_ms());
>  }
>
> -TEST_F(ExternalTabUITest, HostNetworkStackUnresponsiveRenderer) {
> +// Flaky, http://crbug.com/61023.
> +TEST_F(ExternalTabUITest, FLAKY_HostNetworkStackUnresponsiveRenderer) {
>   scoped_refptr<TabProxy> tab;
>   TimedMessageLoopRunner loop(MessageLoop::current());
>   ASSERT_THAT(mock_, testing::NotNull());
>
>
>

Expand Messages | Collapse Messages