chrome/browser/sidebar/sidebar_container.h - Issue 4549003: Coverity: Fix bad overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sidebar/sidebar_container.h

Issue 4549003: Coverity: Fix bad overrides. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sidebar/sidebar_container.h

diff --git a/chrome/browser/sidebar/sidebar_container.h b/chrome/browser/sidebar/sidebar_container.h

index ac74ece10f3b9efa19136f90673e5620a025bfed..0f78988edefbc999dd4eba7c499d6bd1249d1f3b 100644

--- a/chrome/browser/sidebar/sidebar_container.h

+++ b/chrome/browser/sidebar/sidebar_container.h

@@ -105,7 +105,7 @@ class SidebarContainer

virtual void LoadingStateChanged(TabContents* source) {}

virtual void CloseContents(TabContents* source) {}

virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {}

- virtual bool IsPopup(TabContents* source) { return false; }

+ virtual bool IsPopup(TabContents* source) const { return false; }

virtual void URLStarredChanged(TabContents* source, bool starred) {}

virtual void UpdateTargetURL(TabContents* source, const GURL& url) {}

virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) {}

« no previous file with comments | « chrome/browser/extensions/extension_dom_ui.cc ('k') | no next file » | no next file with comments »