Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/extensions/extension_dom_ui.h

Issue 4549003: Coverity: Fix bad overrides. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_dom_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // DOMUI 44 // DOMUI
45 virtual void RenderViewCreated(RenderViewHost* render_view_host); 45 virtual void RenderViewCreated(RenderViewHost* render_view_host);
46 virtual void RenderViewReused(RenderViewHost* render_view_host); 46 virtual void RenderViewReused(RenderViewHost* render_view_host);
47 virtual void ProcessDOMUIMessage(const ViewHostMsg_DomMessage_Params& params); 47 virtual void ProcessDOMUIMessage(const ViewHostMsg_DomMessage_Params& params);
48 48
49 // ExtensionFunctionDispatcher::Delegate 49 // ExtensionFunctionDispatcher::Delegate
50 virtual Browser* GetBrowser() const; 50 virtual Browser* GetBrowser() const;
51 virtual gfx::NativeView GetNativeViewOfHost(); 51 virtual gfx::NativeView GetNativeViewOfHost();
52 virtual gfx::NativeWindow GetCustomFrameNativeWindow(); 52 virtual gfx::NativeWindow GetCustomFrameNativeWindow();
53 virtual TabContents* associated_tab_contents() const; 53 virtual TabContents* associated_tab_contents() const;
54 virtual Profile* GetProfile();
55 54
56 virtual ExtensionBookmarkManagerEventRouter* 55 virtual ExtensionBookmarkManagerEventRouter*
57 extension_bookmark_manager_event_router(); 56 extension_bookmark_manager_event_router();
58 57
59 // BrowserURLHandler 58 // BrowserURLHandler
60 static bool HandleChromeURLOverride(GURL* url, Profile* profile); 59 static bool HandleChromeURLOverride(GURL* url, Profile* profile);
61 60
62 // Register and unregister a dictionary of one or more overrides. 61 // Register and unregister a dictionary of one or more overrides.
63 // Page names are the keys, and chrome-extension: URLs are the values. 62 // Page names are the keys, and chrome-extension: URLs are the values.
64 // (e.g. { "newtab": "chrome-extension://<id>/my_new_tab.html" } 63 // (e.g. { "newtab": "chrome-extension://<id>/my_new_tab.html" }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // TODO(aa): This seems out of place. Why is it not with the event routers for 97 // TODO(aa): This seems out of place. Why is it not with the event routers for
99 // the other extension APIs? 98 // the other extension APIs?
100 scoped_ptr<ExtensionBookmarkManagerEventRouter> 99 scoped_ptr<ExtensionBookmarkManagerEventRouter>
101 extension_bookmark_manager_event_router_; 100 extension_bookmark_manager_event_router_;
102 101
103 // The URL this DOMUI was created for. 102 // The URL this DOMUI was created for.
104 GURL url_; 103 GURL url_;
105 }; 104 };
106 105
107 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_ 106 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_DOM_UI_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_dom_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698