chrome/renderer/resources/extension_process_bindings.js - Issue 454019: Addition of optional giveFocus parameter to experimental.popup.show(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 454019: Addition of optional giveFocus parameter to experimental.popup.show(...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/views/extensions/extension_popup.cc ('K') | « chrome/common/extensions/api/extension_api.json ('k') | chrome/test/data/extensions/api_test/popup_api/toolband.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extension_process_bindings.js

===================================================================

--- chrome/renderer/resources/extension_process_bindings.js (revision 33889)

+++ chrome/renderer/resources/extension_process_bindings.js (working copy)

@@ -425,19 +425,31 @@

this.definition.parameters[0],

{

type: "object",

- name: "domAnchor",

+ name: "showDetails",

properties: {

- top: { type: "integer", minimum: 0 },

- left: { type: "integer", minimum: 0 },

- width: { type: "integer", minimum: 0 },

- height: { type: "integer", minimum: 0 }

+ domAnchor: {

+ type: "object",

+ properties: {

+ top: { type: "integer", minimum: 0 },

+ left: { type: "integer", minimum: 0 },

+ width: { type: "integer", minimum: 0 },

+ height: { type: "integer", minimum: 0 }

+ }

+ },

+ giveFocus: {

+ type: "boolean",

+ optional: true

+ }

}

this.definition.parameters[2]

];

return sendRequest(this.name,

[url,

- getAbsoluteRect(showDetails.relativeTo),

+ {

+ domAnchor: getAbsoluteRect(showDetails.relativeTo),

+ giveFocus: showDetails.giveFocus

+ },

callback],

internalSchema);

}