Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/location_bar_view.cc

Issue 454019: Addition of optional giveFocus parameter to experimental.popup.show(...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/views/extensions/extension_popup.cc ('K') | « chrome/browser/views/extensions/extension_popup.cc ('k') | chrome/common/extensions/api/extension_api.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/location_bar_view.cc
===================================================================
--- chrome/browser/views/location_bar_view.cc (revision 33889)
+++ chrome/browser/views/location_bar_view.cc (working copy)
@@ -1351,8 +1351,11 @@
gfx::Rect rect = parent->bounds();
rect.set_x(origin.x());
rect.set_y(origin.y());
- popup_ = ExtensionPopup::Show(page_action_->popup_url(), browser, rect,
- BubbleBorder::TOP_RIGHT);
+ popup_ = ExtensionPopup::Show(page_action_->popup_url(),
+ browser,
+ rect,
+ BubbleBorder::TOP_RIGHT,
+ true); // Activate the popup window.
popup_->set_delegate(this);
} else {
ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
« chrome/browser/views/extensions/extension_popup.cc ('K') | « chrome/browser/views/extensions/extension_popup.cc ('k') | chrome/common/extensions/api/extension_api.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698