Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/browser_actions_container.cc

Issue 454019: Addition of optional giveFocus parameter to experimental.popup.show(...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_popup_apitest.cc ('k') | chrome/browser/views/extensions/extension_popup.h » ('j') | chrome/browser/views/extensions/extension_popup.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_actions_container.cc
===================================================================
--- chrome/browser/views/browser_actions_container.cc (revision 33889)
+++ chrome/browser/views/browser_actions_container.cc (working copy)
@@ -379,7 +379,8 @@
popup_ = ExtensionPopup::Show(browser_action->popup_url(),
toolbar_->browser(),
rect,
- BubbleBorder::TOP_RIGHT);
+ BubbleBorder::TOP_RIGHT,
+ true); // Activate the popup window.
popup_->set_delegate(this);
popup_button_ = button;
popup_button_->PopupDidShow();
« no previous file with comments | « chrome/browser/extensions/extension_popup_apitest.cc ('k') | chrome/browser/views/extensions/extension_popup.h » ('j') | chrome/browser/views/extensions/extension_popup.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698