Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: src/arm/ic-arm.cc

Issue 454018: Fix megamorphic load regression on ARM caused by the string... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 for (int i = 0; i < kProbes; i++) { 108 for (int i = 0; i < kProbes; i++) {
109 // Compute the masked index: (hash + i + i * i) & mask. 109 // Compute the masked index: (hash + i + i * i) & mask.
110 __ ldr(t1, FieldMemOperand(r2, String::kHashFieldOffset)); 110 __ ldr(t1, FieldMemOperand(r2, String::kHashFieldOffset));
111 if (i > 0) { 111 if (i > 0) {
112 // Add the probe offset (i + i * i) left shifted to avoid right shifting 112 // Add the probe offset (i + i * i) left shifted to avoid right shifting
113 // the hash in a separate instruction. The value hash + i + i * i is right 113 // the hash in a separate instruction. The value hash + i + i * i is right
114 // shifted in the following and instruction. 114 // shifted in the following and instruction.
115 ASSERT(StringDictionary::GetProbeOffset(i) < 115 ASSERT(StringDictionary::GetProbeOffset(i) <
116 1 << (32 - String::kHashFieldOffset)); 116 1 << (32 - String::kHashFieldOffset));
117 __ add(t1, t1, Operand( 117 __ add(t1, t1, Operand(
118 StringDictionary::GetProbeOffset(i) << String::kHashFieldOffset)); 118 StringDictionary::GetProbeOffset(i) << String::kHashShift));
119 } 119 }
120 __ and_(t1, r3, Operand(t1, LSR, String::kHashShift)); 120 __ and_(t1, r3, Operand(t1, LSR, String::kHashShift));
121 121
122 // Scale the index by multiplying by the element size. 122 // Scale the index by multiplying by the element size.
123 ASSERT(StringDictionary::kEntrySize == 3); 123 ASSERT(StringDictionary::kEntrySize == 3);
124 __ add(t1, t1, Operand(t1, LSL, 1)); // t1 = t1 * 3 124 __ add(t1, t1, Operand(t1, LSL, 1)); // t1 = t1 * 3
125 125
126 // Check if the key is identical to the name. 126 // Check if the key is identical to the name.
127 __ add(t1, t0, Operand(t1, LSL, 2)); 127 __ add(t1, t0, Operand(t1, LSL, 2));
128 __ ldr(ip, FieldMemOperand(t1, kElementsStartOffset)); 128 __ ldr(ip, FieldMemOperand(t1, kElementsStartOffset));
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 834
835 // Perform tail call to the entry. 835 // Perform tail call to the entry.
836 __ TailCallRuntime(f, 3, 1); 836 __ TailCallRuntime(f, 3, 1);
837 } 837 }
838 838
839 839
840 #undef __ 840 #undef __
841 841
842 842
843 } } // namespace v8::internal 843 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698