Issue 454001: Merge revisions r3372 - r3374 to trunk...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454001: Merge revisions r3372 - r3374 to trunk... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/1.3/

Visibility:
Public.

Merge revisions r3372 - r3374 to trunk BUG=http://code.google.com/p/v8/issues/detail?id=528, http://crbug.com/23058 TEST=cctest/test-api/Bug528 Committed: http://code.google.com/p/v8/source/detail?r=3378

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -31 lines)			Patch
M	include/v8.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/accessors.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/handles.cc	View	1	3 chunks	+9 lines, -10 lines	0 comments	Download
M	src/messages.js	View		5 chunks	+14 lines, -10 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+86 lines, -0 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Søren Thygesen Gjesse

I will commit this when the Chromium trunk shows green result for the equivalent merge ...

11 years ago (2009-11-30 09:59:03 UTC) #1

LGTM