Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: source/patched-ffmpeg-mt/tools/patcheck

Issue 4533003: patched ffmpeg nov 2 (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/ffmpeg/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/bin/sh 1 #!/bin/sh
2 2
3 # if no argument provided, write stdin to a file and re-run the script 3 # if no argument provided, write stdin to a file and re-run the script
4 if [ $# = 0 ]; then 4 if [ $# = 0 ]; then
5 cat > patcheck.stdout 5 cat > patcheck.stdout
6 $0 patcheck.stdout 6 $0 patcheck.stdout
7 rm -f patcheck.stdout 7 rm -f patcheck.stdout
8 exit 8 exit
9 fi 9 fi
10 10
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 hiegrep2 '\.sample_fmts *= *\(' 'const' 'missing const for sample_fmts array' $* 88 hiegrep2 '\.sample_fmts *= *\(' 'const' 'missing const for sample_fmts array' $*
89 hiegrep2 '\.supported_framerates *= *\(' 'const' 'missing const for supported_fr amerates array' $* 89 hiegrep2 '\.supported_framerates *= *\(' 'const' 'missing const for supported_fr amerates array' $*
90 hiegrep2 '\.channel_layouts *= *\(' 'const' 'missing const for channel_layouts a rray' $* 90 hiegrep2 '\.channel_layouts *= *\(' 'const' 'missing const for channel_layouts a rray' $*
91 91
92 #egrep $OPT '^\+.*const ' $*| grep -v 'static'> $TMP && printf '\nnon static con st\n' 92 #egrep $OPT '^\+.*const ' $*| grep -v 'static'> $TMP && printf '\nnon static con st\n'
93 #cat $TMP 93 #cat $TMP
94 94
95 hiegrep2 "$ERE_TYPES" '(static|av_|ff_|typedef|:\+[^a-zA-Z_])' 'Non static with no ff_/av_ prefix' $* 95 hiegrep2 "$ERE_TYPES" '(static|av_|ff_|typedef|:\+[^a-zA-Z_])' 'Non static with no ff_/av_ prefix' $*
96 96
97 hiegrep ':\+[^}#]*else' 'missing } prior to else' $* 97 hiegrep ':\+[^}#]*else' 'missing } prior to else' $*
98 hiegrep '(if|while|for)\(' 'missing whitespace between keyword and (' $* 98 hiegrep '(if|while|for)\(' 'missing whitespace between keyword and ( (feel free to ignore)' $*
99 hiegrep '(else|do){' 'missing whitespace between keyword and {' $* 99 hiegrep '(else|do){' 'missing whitespace between keyword and { (feel free to ignore)' $*
100 hiegrep '}(else|while)' 'missing whitespace between } and keyword' $* 100 hiegrep '}(else|while)' 'missing whitespace between } and keyword (feel free to ignore)' $*
101 101
102 #FIXME this should print the previous statement maybe 102 #FIXME this should print the previous statement maybe
103 hiegrep ':\+ *{ *$' '{ should be on the same line as the related previous state ment' $* 103 hiegrep ':\+ *{ *$' '{ should be on the same line as the related previous state ment' $*
104 104
105 105
106 rm $TMP 106 rm $TMP
107 for i in `grep -H '^+.*@param' $*| sed 's/^\([^:]*\):.*@param\(\[.*\]\|\) *\([a- zA-Z0-9_]*\) .*$/\1:\3/'` ; do 107 for i in `grep -H '^+.*@param' $*| sed 's/^\([^:]*\):.*@param\(\[.*\]\|\) *\([a- zA-Z0-9_]*\) .*$/\1:\3/'` ; do
108 doxpar=`echo $i | sed 's/^.*:\(.*\)$/\1/'` 108 doxpar=`echo $i | sed 's/^.*:\(.*\)$/\1/'`
109 file=`echo $i | sed 's/^\([^:]*\):.*$/\1/'` 109 file=`echo $i | sed 's/^\([^:]*\):.*$/\1/'`
110 grep " *$doxpar *[),]" $file | grep -v '@param' >/dev/null || grep --color=a lways "@param *$doxpar" $file >>$TMP 110 grep " *$doxpar *[),]" $file | grep -v '@param' >/dev/null || grep --color=a lways "@param *$doxpar" $file >>$TMP
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 167
168 vertical align = 168 vertical align =
169 /* and * align 169 /* and * align
170 arrays fitting in smaller types 170 arrays fitting in smaller types
171 variables written to twice with no interspaced read 171 variables written to twice with no interspaced read
172 memset(block, 0, 6*64*sizeof(DCTELEM)); -> clear_blocks 172 memset(block, 0, 6*64*sizeof(DCTELEM)); -> clear_blocks
173 check existence of long_name in AVCodec 173 check existence of long_name in AVCodec
174 check that the patch does not touch codec & (de)muxer layer at the same time ->s plit 174 check that the patch does not touch codec & (de)muxer layer at the same time ->s plit
175 175
176 write a regression test containing at least a line that triggers each warning on ce 176 write a regression test containing at least a line that triggers each warning on ce
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698