Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4533003: patched ffmpeg nov 2 (Closed)

Created:
10 years, 1 month ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

patched ffmpeg nov 2 BUG=61914 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65186

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3476 lines, -1854 lines) Patch
M README.chromium View 1 3 chunks +59 lines, -41 lines 1 comment Download
M libswscale.tar.gz View 1 3 chunks +675 lines, -664 lines 0 comments Download
M libvpx.tar.gz View Binary file 0 comments Download
M patches/to_upstream/01_static_pthread_O2.patch View 1 7 chunks +29 lines, -12 lines 0 comments Download
M patches/to_upstream/02_mov_dref_looping.patch View 1 1 chunk +4 lines, -4 lines 0 comments Download
M patches/to_upstream/03_mpeg4_video_to_elementary_stream.patch View 1 5 chunks +16 lines, -16 lines 0 comments Download
M patches/to_upstream/04_vc1_bsfs.patch View 1 4 chunks +10 lines, -10 lines 0 comments Download
M patches/to_upstream/05_respect_flac_dirac_configure.patch View 1 3 chunks +10 lines, -10 lines 0 comments Download
M patches/to_upstream/06_remove_decode_on_config_no_svq3.patch View 1 1 chunk +3 lines, -3 lines 0 comments Download
M patches/to_upstream/11_mkv_buffer_overflow.patch View 1 6 chunks +8 lines, -8 lines 0 comments Download
M patches/to_upstream/12_ogg_seek_to_zero.patch View 1 1 chunk +3 lines, -3 lines 0 comments Download
M patches/to_upstream/14_vp8_encode_options.patch View 1 9 chunks +27 lines, -28 lines 0 comments Download
M patches/to_upstream/15_webp_ffmpeg.patch View 1 7 chunks +17 lines, -17 lines 0 comments Download
M patches/to_upstream/16_neon_offsets.patch View 1 1 chunk +3 lines, -3 lines 0 comments Download
A patches/to_upstream/17_mpegthread.patch View 1 chunk +25 lines, -0 lines 0 comments Download
A patches/to_upstream/18_respect_swscale.patch View 1 chunk +64 lines, -0 lines 0 comments Download
M patches/ugly/07_get_bits_overrun.patch View 1 1 chunk +3 lines, -3 lines 0 comments Download
M patches/ugly/08_enforce_theora_oob.patch View 1 3 chunks +6 lines, -6 lines 0 comments Download
M patches/ugly/09_enforce_vorbis_oob_divzero.patch View 1 4 chunks +6 lines, -6 lines 0 comments Download
M patches/ugly/10_aac_oob_read.patch View 1 1 chunk +3 lines, -3 lines 0 comments Download
M patches/ugly/13_remove_avcore.patch View 1 2 chunks +4 lines, -4 lines 0 comments Download
M source/patched-ffmpeg-mt/Changelog View 1 1 chunk +6 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/cmdutils.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/cmdutils.c View 1 7 chunks +75 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/configure View 1 3 chunks +8 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/APIchanges View 1 1 chunk +11 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/ffmpeg-doc.texi View 1 2 chunks +13 lines, -8 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/ffprobe-doc.texi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/filters.texi View 1 6 chunks +124 lines, -11 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/general.texi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/indevs.texi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/doc/protocols.texi View 1 3 chunks +45 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/ffmpeg.c View 1 49 chunks +126 lines, -305 lines 0 comments Download
M source/patched-ffmpeg-mt/ffplay.c View 1 5 chunks +24 lines, -52 lines 0 comments Download
M source/patched-ffmpeg-mt/ffpresets/libvpx-1080p.ffpreset View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/ffpresets/libvpx-1080p50_60.ffpreset View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/ffpresets/libvpx-720p.ffpreset View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/ffpresets/libvpx-720p50_60.ffpreset View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/ffprobe.c View 1 4 chunks +0 lines, -6 lines 0 comments Download
M source/patched-ffmpeg-mt/ffserver.c View 1 3 chunks +20 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/avcodec.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/dxva2_h264.c View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/ffv1.c View 1 23 chunks +454 lines, -146 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/ituh263enc.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/libvorbis.c View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/libvpxenc.c View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/libx264.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/libxvidff.c View 1 1 chunk +5 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/mjpegdec.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/mjpegdec.c View 1 9 chunks +44 lines, -40 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/mpegvideo.c View 1 3 chunks +7 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/options.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/pthread.c View 1 1 chunk +1 line, -1 line 0 comments Download
A source/patched-ffmpeg-mt/libavcodec/targa.h View 1 chunk +36 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/targa.c View 1 1 chunk +1 line, -8 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/targaenc.c View 1 4 chunks +16 lines, -9 lines 0 comments Download
M source/patched-ffmpeg-mt/libavcodec/xan.c View 1 3 chunks +8 lines, -8 lines 0 comments Download
M source/patched-ffmpeg-mt/libavdevice/vfwcap.c View 1 1 chunk +16 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/Makefile View 1 2 chunks +3 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/allfilters.c View 1 2 chunks +3 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/avfilter.h View 1 3 chunks +16 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/avfilter.c View 1 3 chunks +12 lines, -6 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/avfiltergraph.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/avfiltergraph.c View 1 1 chunk +13 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/defaults.c View 1 3 chunks +31 lines, -30 lines 0 comments Download
A source/patched-ffmpeg-mt/libavfilter/vf_cropdetect.c View 1 chunk +214 lines, -0 lines 0 comments Download
A source/patched-ffmpeg-mt/libavfilter/vf_settb.c View 1 chunk +141 lines, -0 lines 0 comments Download
A source/patched-ffmpeg-mt/libavfilter/vf_transpose.c View 1 chunk +212 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/vf_unsharp.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/vsrc_buffer.c View 1 3 chunks +5 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavfilter/vsrc_nullsrc.c View 1 3 chunks +49 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/Makefile View 1 2 chunks +7 lines, -6 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/allformats.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/asfdec.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/asfenc.c View 1 3 chunks +2 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/avformat.h View 1 20 chunks +78 lines, -46 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/avidec.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/avienc.c View 1 3 chunks +2 lines, -7 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/avio.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/flacdec.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/flacenc.c View 1 3 chunks +3 lines, -4 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/id3v2.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/img2.c View 1 6 chunks +33 lines, -42 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/internal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/matroskadec.c View 1 2 chunks +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/matroskaenc.c View 1 3 chunks +2 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/metadata.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/metadata.c View 1 4 chunks +15 lines, -9 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/movenc.c View 1 1 chunk +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/mp3.c View 1 4 chunks +1 line, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/mpegenc.c View 1 1 chunk +6 lines, -4 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/nutdec.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/nutenc.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/oggdec.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/oggenc.c View 1 8 chunks +8 lines, -9 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/oggparsevorbis.c View 1 2 chunks +3 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/oma.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/options.c View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtmpproto.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtpdec.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtpdec.c View 1 9 chunks +39 lines, -38 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtpproto.c View 1 2 chunks +0 lines, -28 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtsp.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/rtsp.c View 1 19 chunks +173 lines, -60 lines 0 comments Download
A source/patched-ffmpeg-mt/libavformat/sapdec.c View 1 chunk +239 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/sdp.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/udp.c View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/utils.c View 1 7 chunks +12 lines, -15 lines 0 comments Download
M source/patched-ffmpeg-mt/libavformat/vorbiscomment.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/libavformat/vorbiscomment.c View 1 1 chunk +4 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/mt-work/test.sh View 1 1 chunk +6 lines, -2 lines 0 comments Download
M source/patched-ffmpeg-mt/tests/ref/lavf/mpg View 1 1 chunk +1 line, -1 line 0 comments Download
M source/patched-ffmpeg-mt/tests/ref/seek/lavf_mpg View 1 1 chunk +27 lines, -27 lines 0 comments Download
M source/patched-ffmpeg-mt/tools/graph2dot.c View 1 2 chunks +4 lines, -5 lines 0 comments Download
M source/patched-ffmpeg-mt/tools/patcheck View 1 1 chunk +3 lines, -3 lines 0 comments Download
M source/patched-ffmpeg-mt/tools/probetest.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fbarchard
tbr=tomf
10 years, 1 month ago (2010-11-05 09:37:38 UTC) #1
Tom Finegan
10 years, 1 month ago (2010-11-05 14:21:33 UTC) #2 
LGTM except for the one comment.

http://codereview.chromium.org/4533003/diff/34002/48005
File README.chromium (right):

http://codereview.chromium.org/4533003/diff/34002/48005#newcode8
README.chromium:8: This corresponds to r2???? in the mainline ffmpeg repository.
Should correct this...

Powered by Google App Engine
This is Rietveld 408576698