Issue 4530003: build_image: enable new cros specific error handling in dm-verity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4530003: build_image: enable new cros specific error handling in dm-verity (Closed)

Created:
10 years, 1 month ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@0.9.110.B

Visibility:
Public.

Description

build_image: enable new cros specific error handling in dm-verity A new error mode for dm-verity exists which can be called as "cros" or "3". This change enables that mode in builds by default. TEST=build_image had the correct argument; functionality was there [in progress] BUG=chromium-os:8442 Change-Id: I3eb3f4a662c5d36011542af4e50718db50ab63bd

Patch Set 1 #

Total comments: 2

Patch Set 2 : wrap line #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build_image	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM w/ nit http://codereview.chromium.org/4530003/diff/1/2 File build_image (right): http://codereview.chromium.org/4530003/diff/1/2#newcode75 build_image:75: "Kernel verified boot error behavior (0: ...

10 years, 1 month ago (2010-11-05 02:51:57 UTC) #2

Will Drewry

10 years, 1 month ago (2010-11-05 02:56:11 UTC) #3

Fixed - thanks!

http://codereview.chromium.org/4530003/diff/1/2
File build_image (right):

http://codereview.chromium.org/4530003/diff/1/2#newcode75
build_image:75: "Kernel verified boot error behavior (0: I/O errors, 1: panic,
2: nothing, 3: cros) \
On 2010/11/05 02:51:58, sosa wrote:
> 80 char

Done.

Expand Messages | Collapse Messages