Issue 4529002: create_legacy_bootloader_templates.sh: ensure grub escapes quotes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4529002: create_legacy_bootloader_templates.sh: ensure grub escapes quotes (Closed)

Created:
10 years, 1 month ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, nsanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@0.9.102.B

Visibility:
Public.

Description

create_legacy_bootloader_templates.sh: ensure grub escapes quotes Evidently no one has tested the grub.cfg since verified boot landed. Grub eats double quotes which breaks verified boot. This changes adds the escapes. No other code changes should be needed in build and install code since they replace DMTABLEA and DMTABLEB and not the quotes. TEST=nsanders escaped the quotes in his build :); I am doing a new build to ensure the output is escaped now. BUG=chrome-os-partner:1603 Change-Id: I55e823347c91493caf3b5b2e4577a4e4616df7f0

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	create_legacy_bootloader_templates.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages